This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
feat: make getEthereumjsTxDataFromTransaction not trim extra fields #7282
Merged
jdevcs
merged 8 commits into
web3:4.x
from
celo-org:nicolasbrugneaux/getEthereumjsTxDataFromTransaction
Sep 26, 2024
Merged
feat: make getEthereumjsTxDataFromTransaction not trim extra fields #7282
jdevcs
merged 8 commits into
web3:4.x
from
celo-org:nicolasbrugneaux/getEthereumjsTxDataFromTransaction
Sep 26, 2024
+122
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
I also took the opportunity to modify |
avkos
approved these changes
Sep 23, 2024
Loading status checks…
…action
jdevcs
approved these changes
Sep 24, 2024
jdevcs
reviewed
Sep 24, 2024
f87e165
to
f176bff
Compare
Loading status checks…
…action
b977445
to
3371c43
Compare
Loading status checks…
…action
@nicolasbrugneaux could you pls test dev release https://www.npmjs.com/package/web3/v/4.13.1-dev.cc99825.0?activeTab=versions in your app. |
Hello! I was OOO for a couple of days. I'll get right on testing that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
getEthereumjsTxDataFromTransaction
to not trim extra fields anymore whilst still aliasinginput
andgasLimit
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.[ Closes #7273 ]