Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - 1.2.3 #3206

Merged
merged 6 commits into from
Nov 14, 2019
Merged

Release - 1.2.3 #3206

merged 6 commits into from
Nov 14, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 14, 2019

Description

This release improves the TS type definitions and does include two smaller patches related to the OOG detection and the provided minified web3 bundle.

Fixed

Compare View

v1.2.2 -> v1.2.3

Type of change

  • Release

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested my code on the live network.

…ed version, CHANGELOG updated and new web3 version defined if required
@nivida nivida added In Progress Currently being worked on Release 1.x 1.0 related issues labels Nov 14, 2019
…s to the root README file with all the required details
…te smaller bundles without the 'browser' entry it's webpack who can't handle this that good
@nivida nivida removed the In Progress Currently being worked on label Nov 14, 2019
Copy link
Contributor

@michaelsbradleyjr michaelsbradleyjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the trigger for all the package-lock.json getting bumped? Mainly, it seem "dev": true got added in various places.

Nevermind, I should have looked at the list of commits in addition to the file changes.

bower.json Show resolved Hide resolved
package.js Show resolved Hide resolved
packages/web3/package.json Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.347% when pulling 80ee9a5 on release/1.2.3 into df9c21d on 1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants