HttpProvider: CORS issue with Firefox and Safari #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivida
added
Bug
|
Added the in-progress label again because it can't find the global |
cgewecke
reviewed
Oct 8, 2019
cgewecke
approved these changes
Oct 8, 2019
|
@cgewecke Yeah, it's really strange and couldn’t clearly figure out why the process global var isn't existing in nodejs v12 for these tests.
I wrote it down on my todo list and will mention it on the missing comment to your e2e issue.
Providers weren’t documented until now. I wrote that down on the todo list as well and will create a related issue for it today. I will merge this PR for now. |
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* CORS error fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2978 and adds the options property
withCredentials.