Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputLogFormatter fix from 1.x forwarded (#3089) #3109

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Oct 8, 2019

Fixes #1100 for the 2.x branch.

  • Adds cases for zero valued fromBlock, toBlock filters.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on 2.x 2.0 related issues labels Oct 8, 2019
@nivida nivida removed the In Progress Currently being worked on label Oct 8, 2019
@coveralls
Copy link

coveralls commented Oct 8, 2019

Coverage Status

Coverage remained the same at 95.914% when pulling 4d63a0f on issue/1100-2.x into 08240ab on 2.x.

@nivida nivida merged commit 3f133c7 into 2.x Oct 8, 2019
@nivida nivida deleted the issue/1100-2.x branch October 11, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x 2.0 related issues Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fromBlock: 0 defaults to latest, fromBlock: 1 works correctly in eth.getPastLogs
2 participants