Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessing event.name where event is undefined #3015

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Fix accessing event.name where event is undefined #3015

merged 2 commits into from
Aug 9, 2019

Conversation

micahriggan
Copy link
Contributor

closes #3014

@nivida nivida added 1.x 1.0 related issues Bug Addressing a bug In Progress Currently being worked on labels Aug 8, 2019
@micahriggan micahriggan force-pushed the fix/web3-contract-event-name branch 2 times, most recently from 008f4de to 87ab9ab Compare August 8, 2019 16:00
@micahriggan
Copy link
Contributor Author

@nivida any tips for the The command "sh -e /etc/init.d/xvfb start" failed and exited with 127 during . issue with travis? Did I do something wrong?

@nivida
Copy link
Contributor

nivida commented Aug 8, 2019

@micahriggan Yes, the fix would be to add xvfb as service as described here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 83.191% when pulling 1683f20 on micahriggan:fix/web3-contract-event-name into 2022b17 on ethereum:1.x.

@nivida nivida removed the In Progress Currently being worked on label Aug 9, 2019
@nivida nivida merged commit 2d0a3f3 into web3:1.x Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@micahriggan @nivida @coveralls