Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3-utils randomHex fix #2430

Closed
wants to merge 6 commits into from
Closed

web3-utils randomHex fix #2430

wants to merge 6 commits into from

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Feb 27, 2019

Description

I've replaced the randomHex dependency and implemented it in the web3.js library based on the code from the randomHex package.

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on the live network.

…e a improved version of it implemented in the web3-utils module
@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Feb 27, 2019
@rstormsf
Copy link

@nivida we need to get this one to merge

@nivida
Copy link
Contributor Author

nivida commented Apr 10, 2019

@rstormsf Currently on vacation until sunday. I’ll be back on Monday:)

@nivida nivida removed Bug Addressing a bug In Progress Currently being worked on labels May 8, 2019
@nivida nivida closed this May 8, 2019
@nivida nivida deleted the issue/1490 branch May 8, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants