Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Masonry] Adding a description and removing compat features #707

Merged
merged 2 commits into from
Mar 21, 2024
Merged

[Masonry] Adding a description and removing compat features #707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfbca7d
Adding a description for Masonry and removing compat features
captainbrosset Mar 19, 2024
7ff2291
Update feature-group-definitions/masonry.yml
captainbrosset Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 1 addition & 6 deletions feature-group-definitions/masonry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
name: Masonry
description: Masonry is a type of CSS grid layout where the items on one of the axes are tightly packed together, like brickwork, instead of leaving gaps to align across the other axis.
spec: https://drafts.csswg.org/css-grid-3/
status:
baseline: false
support: {}
compat_features:
- css.properties.align-tracks
- css.properties.grid-template-columns.masonry
- css.properties.grid-template-rows.masonry
- css.properties.justify-tracks
- css.properties.masonry-auto-flow
Comment on lines -6 to -11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK since were making other changes, but don't take it as a license to seek out every such key just yet. 😄

I think it'll be a lot easier to clean these up when we have the tools to easily determine whether there's a mismatch between web-features and BCD.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks. Especially for cases where we specifically don't want the web-features entry to map 1:1 to what's in BCD.