Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discouraged CSS features #2486

Merged
merged 26 commits into from
Jan 16, 2025
Merged

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Dec 20, 2024

Credit to @vwallen for the content.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Dec 20, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a suggestion for the missing description.

vwallen and others added 2 commits January 6, 2025 08:49

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas here, mostly to avoid having to stuff discouraged information into the IDs and descriptions.

@@ -0,0 +1,11 @@
name: color-adjust
description: The `color-adjust` shorthand CSS property allows multiple performance related color adjustments to be set at once. Setting the `print-color-adjust` CSS property directly is preferred, as it is the only such adjustment so far defined.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking, just noting something here: we ought to come up with guidelines for whether to summarize the alternatives in the description or not.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

media-queries-deprecated.ymldevice-queries.yml

(c.f. several other media query features) and see below

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

features/writing-mode-deprecated.ymlfeatures/writing-mode-svg-values.yml

vwallen and others added 4 commits January 9, 2025 08:35

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit, but this is ready to merge at your convenience.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
vwallen and others added 2 commits January 16, 2025 08:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jamesnw jamesnw requested a review from ddbeck January 16, 2025 16:47
@ddbeck ddbeck merged commit 580ce2c into web-platform-dx:main Jan 16, 2025
3 checks passed
@ddbeck ddbeck changed the title Discouraged CSS features Add discouraged CSS features Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants