[Masonry] Adding a description and removing compat features #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbeck
approved these changes
Mar 20, 2024
Comment on lines
-6
to
-11
| compat_features: | ||
| - css.properties.align-tracks | ||
| - css.properties.grid-template-columns.masonry | ||
| - css.properties.grid-template-rows.masonry | ||
| - css.properties.justify-tracks | ||
| - css.properties.masonry-auto-flow |
There was a problem hiding this comment.
This is OK since were making other changes, but don't take it as a license to seek out every such key just yet. 😄
I think it'll be a lot easier to clean these up when we have the tools to easily determine whether there's a mismatch between web-features and BCD.
There was a problem hiding this comment.
Makes sense to me, thanks. Especially for cases where we specifically don't want the web-features entry to map 1:1 to what's in BCD.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BCD entries for this feature have already been added to the BCD as tags, no need to repeat them here (see this search query).
This PR also adds a short description of the feature.