Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(theme): replace <Fragment /> with <></>, rename SideMenu to SidebarMenu #1932

Merged
merged 3 commits into from
Mar 10, 2025
Merged

chore(theme): replace <Fragment /> with <></>, rename SideMenu to SidebarMenu #1932

merged 3 commits into from
Mar 10, 2025
+16 −20

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Mar 10, 2025 •
edited
Loading

Summary

some small changes

chore(theme): replace with <></>, rename SideMenu to SidebarMenu

#1918

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

@netlify Netlify
Copy link

netlify bot commented Mar 10, 2025 •
edited
Loading

✅ Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 1209dd2
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/67ce9ad2699d7800089004b1
😎 Deploy Preview https://deploy-preview-1932--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 10, 2025 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 1209dd2
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67ce9ad225176a0008256e9e
😎 Deploy Preview https://deploy-preview-1932--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 11 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter
chore: remove Fragment
Loading
Loading status checks…
1209dd2
@SoonIter SoonIter changed the title chore(style): small change in theme packages chore(style): replace <Fragment /> with <></> Mar 10, 2025
@SoonIter SoonIter changed the title chore(style): replace <Fragment /> with <></> chore(theme): replace <Fragment /> with <></>, rename SideMenu to SidebarMenu Mar 10, 2025
@SoonIter SoonIter changed the title chore(theme): replace <Fragment /> with <></>, rename SideMenu to SidebarMenu chore(theme): replace <Fragment /> with <></>, rename SideMenu to SidebarMenu Mar 10, 2025
@SoonIter SoonIter requested a review from Timeless0911 March 10, 2025 08:01
@SoonIter SoonIter merged commit fc6e4c5 into main Mar 10, 2025
16 checks passed
@SoonIter SoonIter deleted the syt/chore/style branch March 10, 2025 08:32
JounQin pushed a commit to JounQin/rspress that referenced this pull request Mar 10, 2025
@SoonIter @JounQin
chore(theme): replace <Fragment /> with <></>, rename SideMenu to `…
4cfb871 
…SidebarMenu` (web-infra-dev#1932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timeless0911 Timeless0911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SoonIter @Timeless0911