Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: deprecate sri option of HTML plugin #9610

Merged
merged 2 commits into from
Mar 10, 2025
Merged

docs: deprecate sri option of HTML plugin #9610

merged 2 commits into from
Mar 10, 2025
+8 −3

Conversation

LingyuCoder
Copy link
Contributor

Summary

The sri option of html rspack plugin only support html tags and not support dynamic import chunk loading. The full-featured SRI has been supported by SubresourceIntegrityPlugin. So the sri option of html rspack should be deprecated.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

@LingyuCoder
docs: deprecate sri of html plugin

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tonistiigi Tõnis Tiigi
GPG key ID: AFA9DE5F8AB7AF39
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
61945db
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: document release: document related release(mr only) labels Mar 10, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 10, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 3df51c7
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67cec2b13ef988000895a87b
😎 Deploy Preview https://deploy-preview-9610--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9610 will not alter performance

Comparing docs/deprecate-html-sri (3df51c7) with main (b1091a9)

Summary

✅ 8 untouched benchmarks

@chenjiahan
Apply suggestions from code review

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tonistiigi Tõnis Tiigi
GPG key ID: AFA9DE5F8AB7AF39
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
3df51c7
@chenjiahan chenjiahan enabled auto-merge (squash) March 10, 2025 10:45
@chenjiahan chenjiahan changed the title docs: deprecate sri of html plugin docs: deprecate sri option of HTML plugin (#9610) Mar 10, 2025
@chenjiahan chenjiahan changed the title docs: deprecate sri option of HTML plugin (#9610) docs: deprecate sri option of HTML plugin Mar 10, 2025
@chenjiahan chenjiahan merged commit 77125d2 into main Mar 10, 2025
31 checks passed
@chenjiahan chenjiahan deleted the docs/deprecate-html-sri branch March 10, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan

Assignees
No one assigned
Labels
release: document release: document related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LingyuCoder @chenjiahan