test: jsdom runner module wrapper #9609
Merged
+89
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
✅ Deploy Preview for rspack canceled.
|
LingyuCoder
changed the title
CodSpeed Performance ReportMerging #9609 will not alter performanceComparing Summary
|
JSerFeng
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The modules of jsdom runner is not wrapped which leads to variable undefined error in lazy compilation test cases.
This pull request introduces several changes to the
JSDOMWebRunnerclass in therspack-test-toolspackage, focusing on improving module content handling and caching. The key changes include adding a new method for retrieving module content, updating the module fetching logic, and implementing a require cache to optimize performance.Checklist