Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css url get target asset module url panic #9607

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Mar 10, 2025

Summary

Fix #9592, an regression introduced by https://github.com/web-infra-dev/rspack/pull/9412/files#diff-1c15f5a8a8d9172d23b16378c2921ade100be73e843e6d9eb2064b7e8bee3c93L38

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 10, 2025
Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit c365215
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67ce98a6b3a03e00089e222a
😎 Deploy Preview https://deploy-preview-9607--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahabhgk ahabhgk requested a review from JSerFeng March 10, 2025 07:47
@ahabhgk ahabhgk enabled auto-merge (squash) March 10, 2025 07:56
Copy link

codspeed-hq bot commented Mar 10, 2025

CodSpeed Performance Report

Merging #9607 will not alter performance

Comparing fix-asset-module-runtime (c365215) with main (f28155c)

Summary

✅ 8 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Rspack 1.2.7 breaks CSS when using Module Federation
2 participants