Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for using id placeholder in the webassemblyModuleFilename #9603

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Mar 9, 2025

Summary

fix #9570

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 9, 2025
Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0028c4c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67cdd8cb1446b70008c1dc47
😎 Deploy Preview https://deploy-preview-9603--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Mar 9, 2025

CodSpeed Performance Report

Merging #9603 will not alter performance

Comparing inottn:fix/wasm (0028c4c) with main (c3272e1)

Summary

✅ 8 untouched benchmarks

Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahabhgk ahabhgk merged commit f28155c into web-infra-dev:main Mar 10, 2025
31 checks passed
@inottn inottn deleted the fix/wasm branch March 10, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: did not resolve wasm module path correctly when set output.webassemblyModuleFilename
2 participants