Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align to wepack chunk load global's double quote #9589

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

stormslowly
Copy link
Contributor

Summary

align chunk_load_global with webpack by changing single quote to double quote.

- (self['chunk_loading_global'] = self['chunk_loading_global'] || []).push([["main"], {
+ (self["chunk_loading_global"] = self["chunk_loading_global"] || []).push([["main"], {

why make this misc pr

it will be assert in next webpack-test, and it brings tons of snapshot update; so i make it in a single pr

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c4d79c3
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67caab15665d180008f1d296

@stormslowly stormslowly enabled auto-merge (squash) March 7, 2025 08:16
Copy link

codspeed-hq bot commented Mar 7, 2025

CodSpeed Performance Report

Merging #9589 will not alter performance

Comparing fix/wepack_chunk_load_align (c4d79c3) with main (62494d6)

Summary

✅ 8 untouched benchmarks

@stormslowly stormslowly merged commit 97163ea into main Mar 7, 2025
31 checks passed
@stormslowly stormslowly deleted the fix/wepack_chunk_load_align branch March 7, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants