Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install nightly components manually #9576

Merged
merged 6 commits into from
Mar 6, 2025
Merged

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Mar 6, 2025

Summary

  1. Nightly will always install rust-docs which rspack does not use if install throw rust-toolchain.toml.
  2. There is no need to store rust cache if it is not on main branch.
  3. Use CI profile to build binding on windows.

Before:
image

After:
image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 6, 2025
Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit aeecf04
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67c97ba6b62f190008303612

Copy link

codspeed-hq bot commented Mar 6, 2025

CodSpeed Performance Report

Merging #9576 will not alter performance

Comparing ci/install-minimal-real (aeecf04) with main (9cdccf7)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 8 untouched benchmarks

@LingyuCoder LingyuCoder marked this pull request as ready for review March 6, 2025 09:52
@LingyuCoder LingyuCoder force-pushed the ci/install-minimal-real branch from fa2ec7c to e02d298 Compare March 6, 2025 10:08
@LingyuCoder LingyuCoder merged commit 19aa1e9 into main Mar 6, 2025
31 checks passed
@LingyuCoder LingyuCoder deleted the ci/install-minimal-real branch March 6, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants