Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary console in test #9565

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Mar 5, 2025

Summary

Remove unnecessary console in tests, which is used to ensure test modules have side effects. But there is better way

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 5, 2025
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bd6e2d9
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67c8223e3bac010008be7fe8

@JSerFeng JSerFeng enabled auto-merge (squash) March 5, 2025 10:10
Copy link

codspeed-hq bot commented Mar 5, 2025

CodSpeed Performance Report

Merging #9565 will not alter performance

Comparing chore/remove-unneccassary (bd6e2d9) with main (07778b2)

Summary

✅ 7 untouched benchmarks

@JSerFeng JSerFeng merged commit 71f783c into main Mar 5, 2025
31 checks passed
@JSerFeng JSerFeng deleted the chore/remove-unneccassary branch March 5, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants