Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix import failed while running cases concurrently #9558

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Mar 5, 2025

Summary

-t can only affect it(), so the build of every case will always compile while running concurrently. So we need to filter it manually to skip the whole describe(). In the future, we can add more filter logic in test creator to improve the DX of -t.


This pull request introduces a new feature to filter tests based on a provided string and includes several related changes across multiple files. The most important changes include adding a shouldRun method to determine if a test should be executed, updating the Jest configuration to support the new test filter, and declaring a global variable for the test filter.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 5, 2025
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit d8e808e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67c7e2f05030730009f68a9c

@LingyuCoder LingyuCoder requested a review from stormslowly March 5, 2025 05:37
Copy link

codspeed-hq bot commented Mar 5, 2025

CodSpeed Performance Report

Merging #9558 will not alter performance

Comparing test/fix-test-filter (d8e808e) with main (f4978db)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@LingyuCoder LingyuCoder enabled auto-merge (squash) March 5, 2025 06:09
@LingyuCoder LingyuCoder merged commit 33ee9e1 into main Mar 5, 2025
33 checks passed
@LingyuCoder LingyuCoder deleted the test/fix-test-filter branch March 5, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants