Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): rspack preview support for nodeEnv flag and default env #9543

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

chenjiahan
Copy link
Member

Summary

Enhance the rspack preview command:

  • Add support for --nodeEnv flag
  • Set process.env.NODE_ENV to production by default (align with Rsbuild and other community tools)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

@chenjiahan chenjiahan requested a review from 9aoy March 4, 2025 09:01
@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 4, 2025
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit ab81644
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67c6c151a7858c0008e5a5f7
😎 Deploy Preview https://deploy-preview-9543--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Mar 4, 2025

CodSpeed Performance Report

Merging #9543 will not alter performance

Comparing preview_env_0304 (ab81644) with main (44f96be)

Summary

✅ 7 untouched benchmarks

@chenjiahan chenjiahan merged commit c8bcb8f into main Mar 4, 2025
31 checks passed
@chenjiahan chenjiahan deleted the preview_env_0304 branch March 4, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants