Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should re-build chunk graph when adding a entry connection #9537

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Mar 3, 2025

Summary

Should re-build chunk graph when adding a entry connection, which connect a module that already exist in the module graph by other connections, checkout the test case for more detail

This fix both incremental and non-incremental for the case, and refactor incremental get_affected_modules_with_chunk_graph: before we use it for moduleHashes, moduleCodegen, and moduleRuntimeRequirement, we use some strategy to guess the affected chunk modules, but we didn't consider an important fact, that the chunk.runtime will also affect, moduleHashes already have a well tested strategy to find all the add/updated chunk modules, so we just to refactor to use moduleHashes to find the affected chunk modules directly

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
ardabbour Abdul Rahman Dabbour
@ahabhgk ahabhgk requested a review from JSerFeng March 3, 2025 13:04
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 3, 2025
@ahabhgk ahabhgk enabled auto-merge (squash) March 3, 2025 13:04
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 18fe28f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67c69c52026f5f0008a5eece
😎 Deploy Preview https://deploy-preview-9537--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 3, 2025
Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Performance Report

Merging #9537 will not alter performance

Comparing fix-dyn-entry-skip (18fe28f) with main (9e1bd1a)

Summary

✅ 7 untouched benchmarks

@ahabhgk ahabhgk merged commit 44f96be into main Mar 4, 2025
29 checks passed
@ahabhgk ahabhgk deleted the fix-dyn-entry-skip branch March 4, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants