fix: should re-build chunk graph when adding a entry connection #9537
+172
−230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should re-build chunk graph when adding a entry connection, which connect a module that already exist in the module graph by other connections, checkout the test case for more detail
This fix both incremental and non-incremental for the case, and refactor incremental
get_affected_modules_with_chunk_graph
: before we use it for moduleHashes, moduleCodegen, and moduleRuntimeRequirement, we use some strategy to guess the affected chunk modules, but we didn't consider an important fact, that thechunk.runtime
will also affect, moduleHashes already have a well tested strategy to find all the add/updated chunk modules, so we just to refactor to use moduleHashes to find the affected chunk modules directlyChecklist