Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change module matchResource in loader #9536

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Mar 3, 2025

Summary

In #9177 we add a getter for Module.matchResource, which means we can't modify matchResource in loader by this._module anymore, this breaks image-minimizer-webpack-plugin

This PR add the setter for compatibility reason, a better solution should be webpack/webpack#18714 (related issue: webpack/webpack#14851)

resolve #9477

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
@ahabhgk ahabhgk requested a review from SyMind March 3, 2025 12:28
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 3, 2025
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 7579d20
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67c5a0642ccf3200077eece3

@ahabhgk ahabhgk enabled auto-merge (squash) March 3, 2025 12:30
Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Performance Report

Merging #9536 will not alter performance

Comparing fix-change-mr-in-loader (7579d20) with main (04f956a)

Summary

✅ 7 untouched benchmarks

@ahabhgk ahabhgk merged commit 0d81442 into main Mar 3, 2025
33 checks passed
@ahabhgk ahabhgk deleted the fix-change-mr-in-loader branch March 3, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: rspack 1.2.3 breaks image-minimizer-webpack-plugin loader
2 participants