fix: change module matchResource in loader #9536
Merged
+61
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #9177 we add a getter for
Module.matchResource
, which means we can't modify matchResource in loader bythis._module
anymore, this breaks image-minimizer-webpack-pluginThis PR add the setter for compatibility reason, a better solution should be webpack/webpack#18714 (related issue: webpack/webpack#14851)
resolve #9477
Checklist