-
-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(memory-allocator): use mimalloc-v3 on macOS and bump mimalloc to v2.1.7 on other platforms #9533
Merged
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
This comment was marked as outdated.
This comment was marked as outdated.
CodSpeed Performance ReportMerging #9533 will not alter performanceComparing Summary
|
chenjiahan
previously approved these changes
Mar 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
… v2.1.9 for other platforms
📝 Benchmark detail: Open
|
Downgraded mimalloc from v2.1.9 to v2.1.7 as windows was not being able to compile. |
chenjiahan
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lifted issue in #8976
According to my investigation, although memory is still growing, upgrading mimalloc to v3 will greatly mitigate the memory bloating issue in development mode. That is to say, memory growing is slower than it was on mimalloc-v2 for each time the compiler rebuilds:
With mimalloc dev3-bin:
With mimalloc dev2-bin (rspack main):
Case: building 10000 modules and rebuild 10 times, for each time a new
console.log
will be written to the entry module.This is the latest version of mimalloc-v2. We don't want to rollout too much change at once. So we're staying at v2 at least for now.
Checklist