fix(html): include innerHTML
content in rendered asset tags
#9526
+60
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was trying to implement an
HtmlRspackPlugin
addition using thealterAssetTags
hook, and for my use case I needed to setinnerHTML
on the generated tag (to get something like<script>console.log("Hello")</script>
). After a lot of confusion about why things weren't showing up as I expected and instead got empty tags, I went to look at the implementation and found thatHtmlPluginTag
was always settingchildren
to an empty vector.This PR fixes that to render the
innerHTML
property of the tag there as a plainText
node if it's present. I also tried to add an end to end test for this, but wasn't able to get them running locally immediately, so hopefully CI will indicate if it's correct, otherwise I'll get them set up and running to try it out.Checklist