-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rust): improve replace_all_placeholder
#9525
refactor(rust): improve replace_all_placeholder
#9525
Conversation
✅ Deploy Preview for rspack canceled.
|
!bench |
Could you help me trigger the benchmark after passing the tests? @chenjiahan |
CodSpeed Performance ReportMerging #9525 will not alter performanceComparing 🎉 Hooray!
|
📝 Benchmark detail: Open
|
Benchmark triggered 😄 |
140c945
to
0e6133f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
0e6133f
to
b6accb2
Compare
📝 Benchmark detail: Open
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
Related to #9304
I made some improvements to ensure optimal performance in general cases while achieving a slight performance boost. Additionally, I fixed boundary errors in the
[hash:8]
case to maintain correctness and ensure consistent performance.Checklist