Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: render runtime template with dojang #9501

Merged
merged 4 commits into from
Mar 4, 2025
Merged

feat: render runtime template with dojang #9501

merged 4 commits into from
Mar 4, 2025
+76 −46

Conversation

GiveMe-A-Name
Copy link
Member

@GiveMe-A-Name GiveMe-A-Name commented Feb 27, 2025 •
edited
Loading

Summary

Use dojang to render runtime modules, related to #5316

More detail summary see: #9079

  • render make_namespace_object template with dojang
  • render node_module_decorator template with dojang
  • render on_chunk_loaded template with dojang

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

@GiveMe-A-Name GiveMe-A-Name marked this pull request as draft February 27, 2025 08:49
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 7b44e83
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67c6672e58799b0008b02e2d
😎 Deploy Preview https://deploy-preview-9501--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 27, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9501 will not alter performance

Comparing feat/runtime-template-with-dojang6 (7b44e83) with main (ec71bd0)

Summary

✅ 7 untouched benchmarks

@GiveMe-A-Name GiveMe-A-Name force-pushed the feat/runtime-template-with-dojang6 branch 2 times, most recently from a041eb2 to 401b9ef Compare February 28, 2025 05:12
@GiveMe-A-Name GiveMe-A-Name marked this pull request as ready for review February 28, 2025 05:59
@GiveMe-A-Name GiveMe-A-Name requested review from SyMind and LingyuCoder and removed request for jerrykingxyz and SyMind February 28, 2025 05:59
@GiveMe-A-Name GiveMe-A-Name enabled auto-merge (squash) February 28, 2025 06:10
@GiveMe-A-Name
feat: render runtime template with dojang
Loading
Loading status checks…
122bf5d
@GiveMe-A-Name GiveMe-A-Name force-pushed the feat/runtime-template-with-dojang6 branch from 401b9ef to 122bf5d Compare March 3, 2025 02:27
LingyuCoder
LingyuCoder previously approved these changes Mar 3, 2025
View reviewed changes
@LingyuCoder LingyuCoder self-requested a review March 3, 2025 02:54
@GiveMe-A-Name GiveMe-A-Name merged commit 1c977b4 into main Mar 4, 2025
27 checks passed
@GiveMe-A-Name GiveMe-A-Name deleted the feat/runtime-template-with-dojang6 branch March 4, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder

@SyMind SyMind

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GiveMe-A-Name @LingyuCoder