Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Set optimization level in per-crate basis #9400

Merged
merged 7 commits into from
Mar 5, 2025

Conversation

kdy1
Copy link
Contributor

@kdy1 kdy1 commented Feb 20, 2025

Summary

This PR reduces the binary size by manually selecting optimization levels for crates.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

kdy1 added 2 commits February 20, 2025 13:20

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit c8c31ca
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67c81dee8b765d0008ca4bdd

@kdy1 kdy1 marked this pull request as ready for review February 20, 2025 05:23
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9400 will not alter performance

Comparing kdy1:size (c8c31ca) with main (07778b2)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@kdy1 kdy1 requested a review from stormslowly February 21, 2025 01:57
@stormslowly
Copy link
Contributor

stormslowly commented Feb 21, 2025

@kdy1
i compare the main branch released .node and current branch released .node

the result is not as expect in my opinion for rspack.linux.*.node

file main branch diff
rspack.darwin-arm64.node 48679024 47787712 -1.83%
rspack.darwin-x64.node 55696144 54364968 -2.39%
rspack.linux-arm64-gnu.node 51590440 61351416 18.92%
rspack.linux-arm64-musl.node 60625992 71944088 18.67%
rspack.linux-x64-gnu.node 60323456 66726456 10.61%
rspack.linux-x64-musl.node 71693760 79292888 10.60%
rspack.win32-arm64-msvc.node 37353472 36690944 -1.77%
rspack.win32-ia32-msvc.node 38904832 37882880 -2.63%
rspack.win32-x64-msvc.node 53959168 52584448 -2.55%

have a look @hardfist

@stormslowly
Copy link
Contributor

latest benchmark base size vs after size

file                            base            after            delta
rspack.darwin-arm64.node        48861360        47955408        -1.85%
rspack.darwin-x64.node          55926232        54637888        -2.30%
rspack.linux-arm64-gnu.node     51812672        50899264        -1.76%
rspack.linux-arm64-musl.node    60856432        59701360        -1.90%
rspack.linux-x64-gnu.node       60578464        59230880        -2.22%
rspack.linux-x64-musl.node      71989744        70289920        -2.36%
rspack.win32-arm64-msvc.node    37544448        36865024        -1.81%
rspack.win32-ia32-msvc.node     39130112        38091264        -2.65%
rspack.win32-x64-msvc.node      54196736        52907008        -2.38%

@stormslowly stormslowly enabled auto-merge (squash) March 5, 2025 12:52
@stormslowly stormslowly merged commit a24494f into web-infra-dev:main Mar 5, 2025
65 checks passed
@chenjiahan
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants