Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: js module graph api #8470

Merged
merged 20 commits into from
Nov 20, 2024
Merged

feat: js module graph api #8470

merged 20 commits into from
Nov 20, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Nov 19, 2024

Summary

Support moduleGraph API. Used by

  1. circular-dependency-plugin
  2. duplicate-package-checker-webpack-plugin

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 19, 2024
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit cb30ad8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/673d94d51332eb00088fde7f

Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #8470 will not alter performance

Comparing module-graph (cb30ad8) with main (687a891)

Summary

✅ 1 untouched benchmarks

@SyMind SyMind marked this pull request as ready for review November 20, 2024 09:04
@SyMind SyMind merged commit 0891a65 into main Nov 20, 2024
33 checks passed
@SyMind SyMind deleted the module-graph branch November 20, 2024 09:44
@@ -95,6 +95,7 @@ export declare class JsCompilation {
importModule(request: string, layer: string | undefined | null, publicPath: JsFilename | undefined | null, baseUri: string | undefined | null, originalModule: string | undefined | null, originalModuleContext: string | undefined | null, callback: any): void
get entries(): JsEntries
addRuntimeModule(chunkUkey: number, runtimeModule: JsAddingRuntimeModule): void
get moduleGraph(): JsModuleGraph
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add it documentation?

SyMind added a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants