Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override default values of some type descriptions #857

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

quanquan2100
Copy link
Contributor

@quanquan2100 quanquan2100 commented Mar 18, 2025

Summary

Fix inaccurate type descriptions in RslibConfig using @override annotation

Related Links

GH-856

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

docs: fix defineConfig type hint
@Timeless0911 Timeless0911 changed the title docs: fix defineConfig type hint fix: override default values of some type descriptions Mar 18, 2025
@Timeless0911
Copy link
Contributor

export interface LibConfig extends EnvironmentConfig { This line use the type EnvironmentConfig, we also need to override in this type when we configure output.target in lib array.

Timeless0911 and others added 2 commits March 18, 2025 16:02
Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Timeless0911 Timeless0911 merged commit be40061 into web-infra-dev:main Mar 18, 2025
14 checks passed
@Timeless0911 Timeless0911 mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants