fix: correct use contextDependencies #846
Merged
+72
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fi3ework
force-pushed
the
contextDependencies
branch
2 times, most recently
from
8885a5c to
e841c1e
Compare
fi3ework
force-pushed
the
contextDependencies
branch
from
e841c1e to
d063eb4
Compare
fi3ework
force-pushed
the
contextDependencies
branch
from
d063eb4 to
736c25b
Compare
Timeless0911
approved these changes
Mar 16, 2025
This was referenced Mar 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
contextDependencies.add()only works with.tapPromisein Rspack now due to a bug, so the hooks name is changed in this PR.Related Links
Checklist