Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standardize logging messages #843

Merged
merged 4 commits into from
Mar 14, 2025
Merged

fix: standardize logging messages #843

merged 4 commits into from
Mar 14, 2025

Conversation

Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Mar 13, 2025

Summary

  • Include several changes to enforce a consistent logging message case convention across the codebase
/**
 * Logging message case convention:
 *
 * Info, ready, success and debug messages:
 * - Start with lowercase
 * - Example: "info  build started..."
 *
 * Errors and warnings:
 * - Start with uppercase
 * - Example: "error  Failed to build"
 *
 * This convention helps distinguish between normal operations
 * and important alerts that require attention.
 */
  • Use rslib as our DEBUG key
  • Add issuer path in logs of module-import-warn cases

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 37c3045
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67d2a99cd367450008cdd915
😎 Deploy Preview https://deploy-preview-843--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 requested a review from fi3ework March 13, 2025 11:22
@Timeless0911 Timeless0911 enabled auto-merge (squash) March 13, 2025 12:13
@Timeless0911 Timeless0911 merged commit be8a4b0 into main Mar 14, 2025
14 checks passed
@Timeless0911 Timeless0911 deleted the fix/debug-logs branch March 14, 2025 03:45
@Timeless0911 Timeless0911 mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants