fix(bundleless): only try to redirect files under outBase dir #760
+78
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fi3ework
force-pushed
the
outbase-external
branch
4 times, most recently
from
33a60f0 to
639eda4
Compare
fi3ework
force-pushed
the
outbase-external
branch
from
639eda4 to
cdff523
Compare
There was a problem hiding this comment.
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (1)
- tests/integration/bundle-false/basic/.gitignore: Language not supported
Comments suppressed due to low confidence (1)
packages/core/src/config.ts:1173
- The error message string should be 'outBase is expected to be a string in bundleless mode, but got ${outBase}' for better clarity.
`outBase expect to be a string in bundleless mode, but got ${outBase}`
Timeless0911
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #759.
Previously, in bundleless mode, files in the
rootfolder underwent the redirect process. This caused files in thenode_modulesdirectory of a non-monorepo project, or the project mentioned in #759, to be redirected unexpectedly.In this PR, only files in the
outBasedirectory will go through the redirect process. TheoutBaserefers to the directory containing the source files, and only imports between these source files should be redirected.Related Links
Checklist