Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type commonjs for all pkgs #822

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

chenjiahan
Copy link
Member

Summary

  • Add type: commonjs in package.json of all packages to avoid potential breakage in future Node versions, see this issue and core-js
  • In the future, we can change the type to esmodule and add .cjs extension for commonjs modules.

Checklist

  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit ce9651a
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/656d38032b0274000850dc83
😎 Deploy Preview https://deploy-preview-822--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan enabled auto-merge (squash) December 4, 2023 02:23
@chenjiahan chenjiahan merged commit 97f5866 into main Dec 4, 2023
10 checks passed
@chenjiahan chenjiahan deleted the type_commonjs_1204 branch December 4, 2023 02:28
@chenjiahan chenjiahan mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant