Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support async function for rsbuildConfig in createRsbuild options #4778

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Mar 13, 2025

Summary

This is one of the prerequisites for implementing the server.restart method.

To allow the loadConfig method to be called again when restarting the server, we need to allow createRsbuild to call loadConfig. Therefore, this PR supports creatingRsbuild's rsbuildConfig to pass in an async function to dynamically load the configuration.

import { createRsbuild, loadConfig } from '@rsbuild/core';

const rsbuild = await createRsbuild({
  rsbuildConfig: async () => {
    const { content } = await loadConfig();
    someFunctionToUpdateConfig(content);
    return content;
  },
});

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit a4e76ee
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67d2b9eef1a78f0008dbe060
😎 Deploy Preview https://deploy-preview-4778--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 54 (🔴 down 21 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

fix
fix
@chenjiahan chenjiahan merged commit 5cc248a into main Mar 13, 2025
10 checks passed
@chenjiahan chenjiahan deleted the async_rsbuild_0313 branch March 13, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant