Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose httpServer in RsbuildDevServer #4570

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Conversation

chenjiahan
Copy link
Member

Summary

Expose httpServer in RsbuildDevServer, this can be used to set up the Rspack lazy compilation backend server.

Example:

const lazyCompilationServerPlugin = (): RsbuildPlugin => {
  return {
    name: 'lazy-compilation-server-plugin',
    setup(api) {
      let devServer: RsbuildDevServer;

      api.onBeforeStartDevServer(({ server }) => {
        devServer = server;
      });

      api.modifyRspackConfig((config) => {
        const { httpServer } = devServer || {};
        if (!httpServer) {
          return;
        }

        config.experiments ||= {};
        config.experiments.lazyCompilation = {
          backend: {
            server: () => httpServer,
          },
        };
      });
    },
  };
};

TODO: Consider adding a new server.middlewareMode config to prevent the unnecessary createHttpServer call.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

netlify bot commented Feb 15, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 88b8d17
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67b091675905eb0008c6be49
😎 Deploy Preview https://deploy-preview-4570--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 48 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 009ec5f into main Feb 15, 2025
15 checks passed
@chenjiahan chenjiahan deleted the http_server_0215 branch February 15, 2025 23:58
@chenjiahan chenjiahan mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant