Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to use native config loader on Windows #4512

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

chenjiahan
Copy link
Member

Summary

Fix failed to use native config loader in Windows.

On Windows, absolute path must be valid file:// URLs, we should use pathToFileURL to process the file path.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

netlify bot commented Feb 9, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 7fd33d0
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67a8225a8861190008e2b902
😎 Deploy Preview https://deploy-preview-4512--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title fix: failed to use native config loader in Windows fix: failed to use native config loader on Windows Feb 9, 2025
@chenjiahan chenjiahan merged commit 37bca3f into main Feb 9, 2025
14 checks passed
@chenjiahan chenjiahan deleted the windows_config_loader_0209 branch February 9, 2025 03:48
@chenjiahan chenjiahan mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant