Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(assets-retry): compile runtime code via Rsbuild plugin #4318

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

chenjiahan
Copy link
Member

Summary

This pull request refactors the build process for the plugin-assets-retry package by moving the runtime code compilation from a separate script to an Rsbuild plugin. This change simplifies the build configuration and removes redundant code.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
szokeasaurusrex Daniel Szoke
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit bc5cf41
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6776953bf8bdaf0008769f2f
😎 Deploy Preview https://deploy-preview-4318--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 52 (🔴 down 21 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit b057d75 into main Jan 2, 2025
10 checks passed
@chenjiahan chenjiahan deleted the assets_retry_runtime_0102 branch January 2, 2025 13:46
@chenjiahan chenjiahan mentioned this pull request Jan 7, 2025
@chenjiahan chenjiahan mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant