Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue2): fix loaders duplicating problem caused by vue-loader@15 #2142

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

xc2
Copy link
Contributor

@xc2 xc2 commented Apr 18, 2024

Summary

Case https://github.com/web-infra-dev/rsbuild/actions/runs/8741123011/job/23986414872?pr=2142

Since I have no idea about the current maintenance status of vue-loader@15, I create this quick fix plugin as an alternative of vuejs/vue-loader#2071

Related Links

fixes #2093

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required). - no need

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit d9a273a
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66214aad9f06d400099ba62b
😎 Deploy Preview https://deploy-preview-2142--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@xc2 xc2 changed the title fix(plugin-vue2): fix stlying loaders duplicating problem caused by vue-loader@17 fix(plugin-vue2): fix stlying loaders duplicating problem caused by vue-loader@15 Apr 18, 2024
@xc2 xc2 changed the title fix(plugin-vue2): fix stlying loaders duplicating problem caused by vue-loader@15 fix(plugin-vue2): fix loaders duplicating problem caused by vue-loader@15 Apr 18, 2024
@xc2 xc2 marked this pull request as ready for review April 18, 2024 17:13
@chenjiahan
Copy link
Member

Nice workaround 👍

We can remove the quick fix plugin after vue-loader@15 release a version or Rsbuild integrated with the Native CSS extract plugin.

@chenjiahan chenjiahan merged commit 970b573 into web-infra-dev:main Apr 19, 2024
12 checks passed
@xc2 xc2 deleted the fix/vue2-style branch April 19, 2024 02:25
@chenjiahan chenjiahan mentioned this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @rsbuild/plugin-vue2 runs duplicating loaders for less code in sfc
2 participants