Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvidia-reranker factory function #1558

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Add nvidia-reranker factory function #1558

merged 4 commits into from
Feb 18, 2025

Conversation

databyjp
Copy link
Contributor

No description provided.

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (92588ed) to head (c13c589).
Report is 198 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/collections/classes/config.py 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1558      +/-   ##
==========================================
- Coverage   90.12%   88.24%   -1.88%     
==========================================
  Files         175      186      +11     
  Lines       15055    15875     +820     
==========================================
+ Hits        13568    14009     +441     
- Misses       1487     1866     +379     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dirkkul dirkkul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you add a unit test here? test/collection/test_config.py :)

@databyjp
Copy link
Contributor Author

Updated!

@dirkkul dirkkul merged commit 734bba1 into main Feb 18, 2025
45 checks passed
@dirkkul dirkkul deleted the 202502/nvidia-patches branch February 18, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants