Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ColBERT vectors #1521

Merged
merged 16 commits into from
Jan 28, 2025
Merged

Conversation

tsmith023
Copy link
Collaborator

No description provided.

…cts + Search
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 changed the title Support multi-vector insertion and querying Add support for colbert vectors Jan 23, 2025
@tsmith023 tsmith023 changed the title Add support for colbert vectors Add support for ColBERT vectors Jan 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 80.80808% with 38 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev/1.29@968fe75). Learn more about missing BASE report.

Files with missing lines Patch % Lines
integration/test_named_vectors.py 53.84% 18 Missing ⚠️
weaviate/collections/grpc/shared.py 87.50% 7 Missing ⚠️
weaviate/util.py 41.66% 7 Missing ⚠️
weaviate/collections/queries/base.py 66.66% 3 Missing ⚠️
weaviate/collections/grpc/query.py 86.66% 2 Missing ⚠️
...aviate/collections/classes/config_named_vectors.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             dev/1.29    #1521   +/-   ##
===========================================
  Coverage            ?   91.05%           
===========================================
  Files               ?      181           
  Lines               ?    15440           
  Branches            ?        0           
===========================================
  Hits                ?    14059           
  Misses              ?     1381           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ctor` to `config.get()` return
@tsmith023 tsmith023 marked this pull request as ready for review January 23, 2025 13:10
@tsmith023 tsmith023 requested a review from a team as a code owner January 23, 2025 13:10
@tsmith023 tsmith023 requested a review from dirkkul January 28, 2025 11:03
@tsmith023 tsmith023 merged commit cfb8081 into dev/1.29 Jan 28, 2025
41 of 42 checks passed
@tsmith023 tsmith023 deleted the modules/support-colbert-multi-vec branch January 28, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants