Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding a location when no config is given #1506

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Jan 10, 2025

No description provided.

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.90%. Comparing base (92588ed) to head (1e11812).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/backup/backup.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   90.12%   89.90%   -0.23%     
==========================================
  Files         175      177       +2     
  Lines       15055    15212     +157     
==========================================
+ Hits        13568    13676     +108     
- Misses       1487     1536      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul merged commit 2c45c1f into main Jan 10, 2025
38 of 39 checks passed
@dirkkul dirkkul deleted the fix_backup_location_without_config branch January 10, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants