Fix: Permanently fixes #69 by forcefully shutting down hanging child process #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has definitely fixed the issue for us where it wouldn't restart if you made changes too quickly, thank you 🙇♀️ |
|
@wclr could we get this bad boy merged in and deployed by any chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the issues described in #69 and I found that none of the proposed solutions were working for me.
In order to reproduce the issue I made sure to trigger a change in my node_modules before my application had fully started up. This seemed to always result in the
SIGTERMbeing swallowed by some other listener instead of properly shutting down the application. This results ints-node-devperpetually hanging.The solution here is to simply send a
SIGINTafter a preset delay if theSIGTERMdoes not result in the application exiting on it's own.