Bump the MSRV from 1.69 to 1.70 #4221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the rust-version in Cargo.toml
…argo.toml is always up to date
Michael-F-Bryan
requested review from
theduke and
ptitSeb
and removed request for
syrusakbary
ptitSeb
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clapcrate upgraded its MSRV from1.64to1.70when releasingv4.4.0(clap-rs/clap#5086). That is forcing thewebccrate to bump the MSRV for its workspace, which in turn forces us to bump the Wasmer repo's MSRV.I've also included an integration test which will make it easier to keep the MSRV in sync in the future. The idea is to automatically detect files you've forgotten to bump the MRSV for, update them, then fail the test with a
"lib/wasi-web/Cargo.toml" was not up to date and has been updated. Please commit the changes and re-run the testsmessage. The MSRV value is all driven from therust-versionin our rootCargo.tomlfile.I've also added the
--lockedflag to all commands in the Makefile. That way, when CI does a build or runs tests, it is guaranteed to use the exact versions mentioned inCargo.lock, and can't automatically use newer versions.