Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update typescript #1528

Merged
merged 13 commits into from
Sep 21, 2023
Merged

chore: update typescript #1528

merged 13 commits into from
Sep 21, 2023

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Sep 4, 2023

Problem

New version of typescript.

TODO:

Solution

Update it. Main change is introduction of enforced pair of module and moduleResolution.
I am putting it to ES2022 and Bundler since our primary consumer of ts build is some bundler.

References

https://devblogs.microsoft.com/typescript/announcing-typescript-5-1/#breaking-changes
https://devblogs.microsoft.com/typescript/announcing-typescript-5-2/#breaking-changes

Probably addresses this one too - #1424

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 27.69 KB (-3.94% 🔽) 554 ms (-3.94% 🔽) 200 ms (-2.9% 🔽) 754 ms
Waku Simple Light Node 262.6 KB (-15.37% 🔽) 5.3 s (-15.37% 🔽) 516 ms (-25.67% 🔽) 5.8 s
ECIES encryption 28.7 KB (+0.07% 🔺) 574 ms (+0.07% 🔺) 224 ms (+26.16% 🔺) 798 ms
Symmetric encryption 28.7 KB (+0.07% 🔺) 575 ms (+0.07% 🔺) 257 ms (+14.32% 🔺) 831 ms
DNS discovery 110.62 KB (-6.72% 🔽) 2.3 s (-6.72% 🔽) 312 ms (-12.69% 🔽) 2.6 s
Privacy preserving protocols 117.38 KB (-4.28% 🔽) 2.4 s (-4.28% 🔽) 402 ms (+2.9% 🔺) 2.8 s
Light protocols 25.83 KB (-12.19% 🔽) 517 ms (-12.19% 🔽) 147 ms (-21.21% 🔽) 664 ms
History retrieval protocols 24.9 KB (-12.34% 🔽) 499 ms (-12.34% 🔽) 186 ms (+28.19% 🔺) 684 ms
Deterministic Message Hashing 5.65 KB (+0.16% 🔺) 113 ms (+0.16% 🔺) 57 ms (+16.21% 🔺) 170 ms

tsconfig.json Outdated Show resolved Hide resolved
typedoc.json Outdated Show resolved Hide resolved
@weboko weboko marked this pull request as ready for review September 5, 2023 23:05
@weboko weboko requested a review from a team as a code owner September 5, 2023 23:05
@weboko weboko mentioned this pull request Sep 7, 2023
24 tasks
Copy link
Collaborator

@fryorcraken fryorcraken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to keep treatWarningAsError so we do not have broken/missing links in the generated docs.

typedoc.json Outdated Show resolved Hide resolved
@weboko weboko merged commit 020463c into master Sep 21, 2023
9 of 10 checks passed
@weboko weboko deleted the weboko/typescript-update branch September 21, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants