Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Update links #2112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Editorial: Update links #2112

wants to merge 2 commits into from

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented Jan 30, 2024

Closes #2111

This PR fixes some links:

  1. Change WCAG 2.1 links to WCAG 2.2
  2. Update various external links to forwarded URLs or found replacement for 404ing links
  3. Replaced http with https
  4. Fixed a typo

Preview | Diff

1. Change WCAG 2.1 links to WCAG 2.2
2. Update various external links to forwarded URLs or found replacement for 404ing links
3. Replaced http with https
4. Fixed a typo
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! looks good to me.

@@ -2193,7 +2193,7 @@ <h2>Definition of Roles</h2>
<rdef>command</rdef>
<div class="role-description">
<p>A form of widget that performs an action but does not receive input data.</p>
<p><code>command</code> is an <a href="#isAbstract">abstract role</a> used for the ontology. Authors MUST NOT use <code>commmand</code> role in content.</p>
<p><code>command</code> is an <a href="#isAbstract">abstract role</a> used for the ontology. Authors MUST NOT use <code>command</code> role in content.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@spectranaut spectranaut changed the title Update links Editorial: Update links Feb 1, 2024
Copy link
Member

@pkra pkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stopping here.

We need to sort out the conflicts with #2102

I suspect this will needs some work once that's resolved.

@@ -93,7 +93,7 @@
</dd>
<dt><dfn>Keyboard Accessible</dfn></dt>
<dd>
<p>Accessible to the user using a keyboard or <a>assistive technologies</a> that mimic keyboard input, such as a sip and puff tube. References in this document relate to <cite><a href="https://www.w3.org/TR/WCAG21/#keyboard-accessible"><abbr title="Web Content Accessibility Guidelines">WCAG</abbr> 2.1 Guideline 2.1: Make all functionality available from a keyboard</a></cite> [[WCAG21]].</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to anything in ./common must be made in https://github.com/w3c/aria-common/ - otherwise they will be reversed on the next aria-common update.

@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml" lang="en-US" xml:lang="en-US">
<html xmlns="https://www.w3.org/1999/xhtml" lang="en-US" xml:lang="en-US">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be reverted. The official namespace URI is still http and https would formally be different. (Even if you end up on https when you visit it, the page says that the URI is http.)

index.html Outdated
@@ -57,7 +57,7 @@
{
name: "Michael Cooper",
company: "W3C",
companyURL: "http://www.w3.org",
companyURL: "https://www.w3.org",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I thought this and some of the other links (around AAPIs) was already changed in #2102

But now I see that that @daniel-montalvo 's PR went into the 1.3 FWPD branch, not main

This will cause merge issues down the line.

@daniel-montalvo can you help rebase things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing links
4 participants