Editorial: Clarify aria-expanded guidance #1980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkra
added
the
clarification
|
Hey @scottaohara, how about this second revision? In anticipation of #1965, I went ahead and killed off the “ownership” terminology and used |
scottaohara
reviewed
Aug 17, 2023
scottaohara
reviewed
Aug 17, 2023
scottaohara
reviewed
Aug 17, 2023
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
|
Thanks for the code suggestions and feedback, @scottaohara. 🙏🏻 I’ve added two markup examples to help illustrate the differences. |
scottaohara
approved these changes
Sep 5, 2023
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
spectranaut
changed the title
|
@aardrian this was lacking a 3rd reviewer. Would you be able to take a look? |
|
@curtbellew can you please review this - we would like to get it merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1912
Clarifies authoring guidance for
aria-expandedby discouraging ownership of the controlled grouping element except in the cases oftreeitemandrow.Preview | Diff