Refactor horizontal color viewer slider test plan to V2 of test format #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y use the property name 'screenText'
… to assertions, move setupScriptDescription to new scripts.csv, change order of columns in commands.csv
… multiple assertion forms
…ertionStatements in assertions.csv
howard-e
reviewed
Aug 24, 2023
Comment on lines
+10
to
+13
| aria-valuenow,aria,aria-valuenow,aria-valuenow | ||
| aria-valuemin,aria,aria-valuemin,aria-valuemin | ||
| aria-valuemax,aria,aria-valuemax,aria-valuemax |
There was a problem hiding this comment.
Suggested change
| aria-labelledby,aria,aria-labelledby,aria-labelledby | |
| aria-valuenow,aria,aria-valuenow,aria-valuenow | |
| aria-valuemin,aria,aria-valuemin,aria-valuemin | |
| aria-valuemax,aria,aria-valuemax,aria-valuemax | |
| aria-labelledby,specification,https://w3c.github.io/aria/#aria-labelledby,aria-labelledby | |
| aria-valuenow,specification,https://w3c.github.io/aria/#aria-valuenow,aria-valuenow | |
| aria-valuemin,specification,https://w3c.github.io/aria/#aria-valuemin,aria-valuemin | |
| aria-valuemax,specification,https://w3c.github.io/aria/#aria-valuemax,aria-valuemax |
Based on V2 definition spec > references.csv > values if I'm following this correctly
There was a problem hiding this comment.
I was experimenting with a new references.csv format that is simpler for authors and creates a single source of truth for specification URLs in support.json. I've now documented the new references.csv format and updated support.json. For spec referencs that have a reference type of aria or htmlAam, the value column no longer needs to include URLs. URLs are still necessary for references of type metadata.
support.json: * add strings to support screen reader settings and assertion tokens. * Add URL data for ARIA and HTML-AAM specifications. commands.json: Add all the command string representations necessary for the new V2 test format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Tests
This pull request refactors the test plan to the new V2 test format. The changes made in version 2 of the test plan format are described in #974.
Note that this test plan cannot be built and previewed until the build script is modified to support the V2 format as described in #977.