Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty values in startup script request struct #299

Merged

Conversation

optik-aper
Copy link
Member

@optik-aper optik-aper commented Feb 28, 2024

Description

Adds the omitempty struct tag since it's the same struct used for update as is used for create. As it is now, when updates are made, any empty values get sent to the API which will wipe the values.

Related Issues

#295

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@optik-aper optik-aper added the bug Something isn't working label Feb 28, 2024
@optik-aper optik-aper self-assigned this Feb 28, 2024
@optik-aper optik-aper merged commit 23320a4 into vultr:master Feb 28, 2024
4 of 5 checks passed
@optik-aper optik-aper deleted the allow-empty-values-on-script-updates branch February 28, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants