Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useMutationObserver): add takeRecords function #3480

Merged
merged 1 commit into from
Nov 9, 2023

feat(useMutationObserver): add `takeRecords` function

a4d76ea
Select commit
Failed to load commit list.
Merged

feat(useMutationObserver): add takeRecords function #3480

feat(useMutationObserver): add `takeRecords` function
a4d76ea
Select commit
Failed to load commit list.
Deleted GitHub App / Copilot for PRs succeeded Oct 17, 2023 in 3s

Analysis complete

Summary

This pull request adds a takeRecords function to the useMutationObserver hook, which lets users access the mutation records without affecting the observer. It also adds a test case for this feature in index.test.ts.

Walkthrough

  • Implement and expose takeRecords function for useMutationObserver hook (link,link)

  • Add test case for takeRecords function in index.test.ts (link)

    Poem

    Oh we're the coders of the useMutationObserver hook

We watch the changes in the DOM with a keen eye
We added a feature to take the records in a jiffy
And we test it well with Vue and Jest, so sing aye aye

Emoji

✨✅📝

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 23.6 seconds
packages/core/useMutationObserver/index.test.ts ✅ Finished 12 seconds
packages/core/useMutationObserver/index.ts ✅ Finished 14.1 seconds