Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useWebNotification): condition check on permission #3422

Merged
merged 1 commit into from Oct 7, 2023

Conversation

SampsonCrowley
Copy link
Contributor

@SampsonCrowley SampsonCrowley commented Sep 22, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

show should bail if not supported or permission not granted. not and

Additional context

related to #3314

fixing a logic branch from #3325


🤖 Generated by Copilot at 1d30339

Fixed a bug in useWebNotification that caused errors when notifications were not supported or allowed. Changed the condition to use || instead of && in packages/core/useWebNotification/index.ts.

🤖 Generated by Copilot at 1d30339

  • Fix a bug where notifications would be shown even if not supported or permitted (link)

show should bail if not supported _or_ permission not granted. not _and_
@antfu antfu changed the title fix: Typo in Notification Permission Conditional fix(useWebNotification): condition check on permission Sep 22, 2023
@antfu antfu enabled auto-merge October 7, 2023 07:02
@antfu antfu added this pull request to the merge queue Oct 7, 2023
Merged via the queue into vueuse:main with commit 2f2b492 Oct 7, 2023
5 checks passed
@SampsonCrowley SampsonCrowley deleted the patch-1 branch October 17, 2023 16:08
@jamols09
Copy link

jamols09 commented Jan 5, 2024

Hi the useWebNotification is not working on the website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants