Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate the codePlugin from @vuepress/markdown to plugin-prismjs #136

Closed
wants to merge 11 commits into from

Conversation

pengzhanbo
Copy link
Member

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

see vuepress/core#1550

Screenshots

Before

After

@coveralls
Copy link

coveralls commented May 15, 2024

Pull Request Test Coverage Report for Build 9124434582

Details

  • 84 of 89 (94.38%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.2%) to 51.909%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/plugin-prismjs/src/node/resolveHighlighter.ts 0 2 0.0%
plugins/plugin-prismjs/src/node/prismjsPlugin.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 9123655949: 2.2%
Covered Lines: 771
Relevant Lines: 1350

💛 - Coveralls

@meteorlxy
Copy link
Member

Please also migrate and try to improve the test cases. Code fence plugin is an important feature.

@pengzhanbo
Copy link
Member Author

Please also migrate and try to improve the test cases. Code fence plugin is an important feature.

Added test cases identical to the codePlugin in @vuepress/core.

@pengzhanbo
Copy link
Member Author

The current PR has been merged into #137, so close this PR and continue the discussion in #137.

@pengzhanbo pengzhanbo closed this May 17, 2024
@pengzhanbo pengzhanbo deleted the plugin-prismjs branch May 19, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants